fix: error in ci when interactive inputs are required by zimeg · Pull Request #468 · slackapi/slack-cli

zimeg · 2026-04-03T05:39:40Z

Changelog

Errors will appear sooner in CI and scripting setups if interactive input or a confirmation is requested. This guards against waiting until a timeout.

Summary

This PR fixes an error in CI when interactive inputs are required.

Preview

Login command

Update command

Reviewers

$ slack create | cat  # No change
$ slack login | cat   # Now errors
$ slack update | cat  # Now errors

Notes

Some prompts don't have flag substitutes at this time but either might not have a required input or might need a flag option. This is saved for follow up PR but aligns more with the style guides:

slack-cli/.github/STYLE_GUIDE.md

Lines 16 to 22 in 5ee9e10

    
           ### Prompts are Flags with Forms 
        
           When information is needed we can prompt for text, confirmation, or a selection. 
        
           These decisions can be made in an interactive terminal (TTY) or not, such as in a scripting environment. 
        
           A flag option should exist for each prompt with a form fallback. Either default values should be used if forms are attempted in a non-TTY setup or an error and remmediation to use a flag should be returned.

Hopes to address an initial issue of feat: Add flags for prompt values to upgrade command #87! 🏁

Requirements

I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.

zimeg

🦠 More comments to the kind reviewers!

zimeg · 2026-04-03T05:40:49Z

internal/iostreams/prompts.go

+	if !io.IsTTY() {
+		return nil, errInteractivityFlags(MultiSelectPromptConfig{})
+	}


🔬 note: Here is the implementation of this function, with a default for no flags:

slack-cli/internal/iostreams/prompts.go

Lines 166 to 190 in 3215666

// errInteractivityFlags formats an error for when flag substitutes are needed

func errInteractivityFlags(cfg PromptConfig) error {

flags := cfg.GetFlags()

var remediation string

var helpMessage = "Learn more about this command with `--help`"

if len(flags) == 1 {

remediation = fmt.Sprintf("Try running the command with the `--%s` flag included", flags[0].Name)

helpMessage = "Learn more about this flag with `--help`"

} else if len(flags) > 1 {

var names []string

for _, flag := range flags {

names = append(names, flag.Name)

}

flags := strings.Join(names, "`\n `--")

remediation = fmt.Sprintf("Consider using the following flags when running this command:\n `--%s`", flags)

helpMessage = "Learn more about these flags with `--help`"

}

return slackerror.New(slackerror.ErrPrompt).

WithDetails(slackerror.ErrorDetails{

slackerror.ErrorDetail{Message: "The input device is not a TTY or does not support interactivity"},

}).

WithRemediation("%s\n%s", remediation, helpMessage)

}

codecov · 2026-04-03T05:42:20Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.08%. Comparing base (c56ad55) to head (752d4cc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   71.07%   71.08%   +0.01%     
==========================================
  Files         220      220              
  Lines       18504    18512       +8     
==========================================
+ Hits        13151    13160       +9     
+ Misses       4178     4177       -1     
  Partials     1175     1175

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

srtaalej

LGTM! thanks for catching and fixing this 🎣 ⭐

zimeg · 2026-04-07T06:49:30Z

@srtaalej Let's continue our quest to better experience of error! 🪬

fix: error in ci when interactive inputs are required

3215666

zimeg added this to the Next Release milestone Apr 3, 2026

zimeg self-assigned this Apr 3, 2026

zimeg requested a review from a team as a code owner April 3, 2026 05:39

zimeg added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented changelog Use on updates to be included in the release notes semver:patch Use on pull requests to describe the release version increment labels Apr 3, 2026

zimeg commented Apr 3, 2026

View reviewed changes

srtaalej approved these changes Apr 6, 2026

View reviewed changes

srtaalej and others added 2 commits April 6, 2026 18:13

Merge branch 'main' into zimeg-fix-ci-prompt-hangs

09c5068

Merge branch 'main' into zimeg-fix-ci-prompt-hangs

752d4cc

zimeg enabled auto-merge (squash) April 7, 2026 06:49

zimeg merged commit a6658e3 into main Apr 7, 2026
8 checks passed

zimeg deleted the zimeg-fix-ci-prompt-hangs branch April 7, 2026 06:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: error in ci when interactive inputs are required#468

fix: error in ci when interactive inputs are required#468
zimeg merged 3 commits intomainfrom
zimeg-fix-ci-prompt-hangs

zimeg commented Apr 3, 2026

Uh oh!

zimeg left a comment

Uh oh!

zimeg Apr 3, 2026

Uh oh!

codecov bot commented Apr 3, 2026 •

edited

Loading

Uh oh!

srtaalej left a comment

Uh oh!

zimeg commented Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	### Prompts are Flags with Forms

	When information is needed we can prompt for text, confirmation, or a selection.

	These decisions can be made in an interactive terminal (TTY) or not, such as in a scripting environment.

	A flag option should exist for each prompt with a form fallback. Either default values should be used if forms are attempted in a non-TTY setup or an error and remmediation to use a flag should be returned.

	// errInteractivityFlags formats an error for when flag substitutes are needed
	func errInteractivityFlags(cfg PromptConfig) error {
	flags := cfg.GetFlags()
	var remediation string
	var helpMessage = "Learn more about this command with `--help`"

	if len(flags) == 1 {
	remediation = fmt.Sprintf("Try running the command with the `--%s` flag included", flags[0].Name)
	helpMessage = "Learn more about this flag with `--help`"
	} else if len(flags) > 1 {
	var names []string
	for _, flag := range flags {
	names = append(names, flag.Name)
	}
	flags := strings.Join(names, "`\n `--")
	remediation = fmt.Sprintf("Consider using the following flags when running this command:\n `--%s`", flags)
	helpMessage = "Learn more about these flags with `--help`"
	}

	return slackerror.New(slackerror.ErrPrompt).
	WithDetails(slackerror.ErrorDetails{
	slackerror.ErrorDetail{Message: "The input device is not a TTY or does not support interactivity"},
	}).
	WithRemediation("%s\n%s", remediation, helpMessage)
	}

Conversation

zimeg commented Apr 3, 2026

Changelog

Summary

Preview

Login command

Update command

Reviewers

Notes

Requirements

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

zimeg Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

srtaalej left a comment

Choose a reason for hiding this comment

Uh oh!

zimeg commented Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Apr 3, 2026 •

edited

Loading